Pull requests

When you want your work to be reviewed by the team and eventually to be landed on the main branch, raise a pull request in Github.

• You can raise a pull request at any time during the progress of your work.

  TIP

  It’s a good idea to do this sooner than later, as pushing your local branch to Github gets it off of your machine and serves as a remote backup.

• If the PR relates to a ticket (which it should in most instances) prefix the ticket name in the PR title, e.g. [PROD-348]: not_using cancellation journey landing page

• Until the PR is ready for review, set the Github status to “work in progress”

• When the PR is ready for review

  • Ensure the pull request template is filled out correctly (including the Asana link(s) to any relevant tasks)
  • Set the Github PR status to “ready for review”
  • Request a review from the bbcmaestro/engineering team

NOTE

🔬 The team is currently trialling “PR stacks” in Github for when work is based off other work that isn’t yet in main